Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add allowed option for inline/block attributes #115

Merged

Conversation

joker21663
Copy link
Contributor

adding allowed attributes to protect against XSS attacks.
An example of such an attack:
asd{onerror="alert(1)"}

maximkurbatov and others added 2 commits September 2, 2024 13:50
An example of such an attack:
![asd](-1){onerror="alert(1)"}
mdit_py_plugins/attrs/index.py Outdated Show resolved Hide resolved
mdit_py_plugins/attrs/index.py Outdated Show resolved Hide resolved
@chrisjsewell
Copy link
Member

@joker21663 I reworked your PR 😅; to also work for blocks, and add a test

If you wanna have a look and comment before I merge

chrisjsewell
chrisjsewell previously approved these changes Sep 9, 2024
@chrisjsewell chrisjsewell changed the title adding allowed attributes to protect against XSS attacks. ✨ Add allowed option for inline/block attributes Sep 9, 2024
@joker21663
Copy link
Contributor Author

@joker21663 I reworked your PR 😅; to also work for blocks, and add a test

If you wanna have a look and comment before I merge

I'm not a programmer. I am a user who was forbidden by the security service to use your plugin without modification). I believe your code and I'm waiting for the merge and the new version so that I can use the plugin and make life easier for our accounting department. Thank you.

@chrisjsewell chrisjsewell merged commit 10d5b4d into executablebooks:master Sep 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants